Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.0 Deployment #159

Merged
merged 200 commits into from
Dec 20, 2023
Merged

7.0 Deployment #159

merged 200 commits into from
Dec 20, 2023

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Dec 11, 2023

LadybugTools_Toolkit

Feature

Bug

Compliance

Uncategorised

BHoMBot and others added 30 commits September 25, 2023 14:31
@BHoMBot
Upgrade AssemblyFileVersion to 7.0.0.0
3ad40ee
Update AssemblyFileVersion to 7.0 (#118)
1519469
@BHoMBot
Upgrade AssemblyFileVersion to 7.0.0.0
89735ef
Remove 6.3 PreviousVersion Attributes (#119)
19bbfa4
Upgrade to .NetStandard 2.0
a130fd1
@BHoMBot
Update project compliance
1bf20a1
Upgrade to .NetStandard 2.0 (#124)
8cfeb4b
@jamesramsden-bh
Added draft nuspec file
b5caa2c
@jamesramsden-bh
Renamed nuspec file
0f17180
@jamesramsden-bh
Handover to Fraser
e5f8ed2
Save point pending upgrade to .NetStandard
c1e8b8f
Resolve conflict marker
d0b221c
Fix Versioning file name
e67a499
Fix versioning file name complete
aa251a0
Complete nuspec file
001e6d9
Add nuspec template file (#125)
61dd48a
@BHoMBot
Update readme links and references
8fdd09c
Update README links and references (#126)
7d8c84c
@tg359
started fresh from weird commit issue
0ebc01b
@tg359
logging changes
60508da
@tg359
typology reworked
30d81c1
@tg359
Major changes
c480e2d
@tg359
changes
6317ceb
@tg359
added Wind.from_uv method
a839a7c
@tg359
Overhauled tests and updated all methods to be more strict around typing
e7c4644
@tg359
rebased to origin/develop
4758c85
@tg359
Added Panel.ToShelter method
e69c65f
@tg359
made methods extension methods
cb5ed08
@tg359
fixing installer lib
8b82599
Fix compilation for core check
5103cd7
@FraserGreenroyd FraserGreenroyd added type:compliance Non-conforming to code guidelines type:feature New capability or enhancement and removed type:compliance Non-conforming to code guidelines labels Dec 11, 2023
@FraserGreenroyd FraserGreenroyd self-requested a review December 11, 2023 10:16
@Tom-Kingstone
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci BHoMBot-CI
Copy link
Author

bhombot-ci bot commented Dec 12, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check unit-tests

@Tom-Kingstone Tom-Kingstone self-requested a review December 19, 2023 09:25
Tom-Kingstone
Tom-Kingstone approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the current LadybugTools_Toolkit test procedure, with 7.0.231219. All tests passing (also tested by @albinber with all tests passing). Approved for deployment.

@tg359 tg359 self-requested a review December 19, 2023 10:01
tg359
tg359 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@tg359 tg359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the current LadybugTools_Toolkit test procedure, with 7.0.231219. All tests passing. Approved for deployment.

@jamesramsden-bh
Copy link
Contributor

Interim approval of this PR based on testing up to 19/12/23, as recorded in the 7.0 S&P testing record.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci BHoMBot-CI
Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 228 requests in the queue ahead of you.

@bhombot-ci BHoMBot-CI
Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Versioning_Toolkit

@bhombot-ci BHoMBot-CI
Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci BHoMBot-CI
Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation

There are 97 requests in the queue ahead of you.

FraserGreenroyd
FraserGreenroyd approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs have been reviewed by DevOps and are suitable for the deployment of develop to the 7.0 beta. Approving for merge.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core

@bhombot-ci BHoMBot-CI
Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@bhombot-ci BHoMBot-CI
Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd merged commit 8235f6f into main Dec 20, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tom-Kingstone Tom-Kingstone Tom-Kingstone approved these changes

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@tg359 tg359 tg359 approved these changes

Assignees

@BHoMBot BHoMBot

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tom-Kingstone @jamesramsden-bh @FraserGreenroyd @tg359 @BHoMBot